Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Jasper Gemstone Color #2257

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

lunaynx
Copy link
Contributor

@lunaynx lunaynx commented Jul 25, 2024

What

Fixed the check for Jasper gemstones using pink color instead of magenta.

Images

image

Changelog Technical Details

  • Fixed wrong color for Jasper gemstone in OreBlock API. - Luna

It is magenta stained glass, not pink.
@github-actions github-actions bot added the Bug Fix Bug fixes label Jul 25, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 25, 2024
@Thunderblade73
Copy link
Contributor

Could you validated if that is also the case in the mineshafts? Since I remember that they glass color for jasper was strange. Since it is very much possible that hypixel messed the color up and the feature got it right for the mineshafts, since that was the original intendet purpose.

@lunaynx
Copy link
Contributor Author

lunaynx commented Jul 25, 2024

I'll try, but it may take me a while to get a Jasper mineshaft.

@lunaynx lunaynx marked this pull request as draft July 27, 2024 09:24
@lunaynx
Copy link
Contributor Author

lunaynx commented Aug 7, 2024

Confirmed it's the same in mineshafts.

@lunaynx lunaynx marked this pull request as ready for review August 7, 2024 11:27
@hannibal002 hannibal002 merged commit 2bdf022 into hannibal002:beta Aug 8, 2024
5 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Aug 8, 2024
@lunaynx lunaynx deleted the fix/jasper-color branch October 11, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants