Feature + Fix: Hoppity Event Summarization #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannibal002
changed the title
|
Couple bugs I need to fix still:
|
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
hannibal002
requested changes
Aug 25, 2024
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityAPI.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityRabbitRarity.kt
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
Waiting on Hypixel
MTOnline69
pushed a commit
to MTOnline69/SkyHanni
that referenced
this pull request
Sep 11, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://discord.com/channels/997079228510117908/1262558938650378250
Adds a recap for Hoppity Events, added an event that gets fired when a rabbit is collected. Reworked the
HoppityEggTypeenum. Tangentially related to the enum, this PR also adds functionality for Hoppity Compact to compact:Images
Changelog New Features
Changelog Fixes
Changelog Technical Details
HoppityAPI, which should house event-specific features rather thanChocolateFactoryAPI. - DaveedAlways Hoppitydev config option, which will overrideisHoppityEvent.RabbitFoundEvent, which will be fired when a chocolate rabbit is found from an egg, bought from Hoppity, or claimed from a milestone. - DaveedSIDE_DISH,CHOCOLATE_SHOP_MILESTONE,CHOCOLATE_FACTORY_MILESTONE, andBOUGHTasHoppityEggTypeoptions. - Daveed