Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Repo Errors #2338

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Improvement: Repo Errors #2338

merged 2 commits into from
Aug 14, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Aug 12, 2024

What

This PR tries to remove all repo item error related chat messages for users.
This should reduce the amount of bug reports on discord.
Instead, the item names for unknown items will now show in red the internal name, and item stacks will show as barriers.

Optionally, we will also show the "missing neu repo" error popup from NEU. I'm not sure if we want to include this, though. (the function call is currently commented out).

Additionally, the debug mode will show the errors in chat, and /shdebug will also keep track of all failed items.

To test this PR, simply remove some/many/all item files from your local repo folder and see what happens (don't forget to restart, caches exist)

/shdebug example
= Debug Information for SkyHanni 0.26.Beta.22 =

no search specified, only showing interesting stuff:

== Item Repo Data ==
 Missing repo items: 33
  - itemname:Carrot
  - internalName:ASPECT_OF_THE_VOID
  - itemname:Melon
  - internalName:IMPLOSION_SCROLL
  - internalName:FLAWLESS_SAPPHIRE_GEM
  - internalName:PERFECT_JASPER_GEM
  - internalName:DARK_CLAYMORE
  - internalName:ARROW_SWAPPER
  - internalName:ICE_SPRAY_WAND
  - internalName:BONZO_MASK
  - internalName:HEARTFIRE_DAGGER
  - internalName:OPAL_POWER_SCROLL
  - internalName:FIRE_VEIL_WAND
  - internalName:KUUDRA_SHOP_ITEM
  - internalName:DAEDALUS_AXE
  - internalName:HYPERION
  - internalName:ANCESTRAL_SPADE
Images

image
image
image

image

Changelog Improvements

  • Hide repository errors in chat. - hannibal2
    • Errors will be displayed directly in the GUI when necessary, making them less intrusive.

Changelog Technical Details

  • Removed repository item errors. - hannibal2
    • Instead of stack traces for "no item name for internal name", "no item stack for internal name", and "no internal name for item stack", we now return the internal name in red, the internal name MISSING_ITEM, or a barrier item instead.
    • Command /shdebug lists all failed item names.
    • Debug chat still logs the errors.
    • Shows a popup (currently disabled).

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Aug 12, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Aug 12, 2024
@github-actions github-actions bot added the Bug Fix Bug fixes label Aug 12, 2024
@hannibal002 hannibal002 requested a review from CalMWolfs August 13, 2024 00:07
@hannibal002 hannibal002 changed the title Fix: Repo Errors Improvement: Repo Errors Aug 13, 2024
@github-actions github-actions bot removed the Bug Fix Bug fixes label Aug 13, 2024
@hannibal002 hannibal002 merged commit 0a027ea into beta Aug 14, 2024
9 checks passed
@hannibal002 hannibal002 deleted the fix/poof-all-repo-errors-gone branch August 14, 2024 10:41
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants