-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Dungeon Secret Chime #2478
Conversation
- Improvement: Dungeon Highlight Clicked Blocks
This is a technical change. Not an improvements, since this is not a user side imporvement and everything dev related lands in the Technical Details. |
This is a succession of #2453 |
src/main/java/at/hannibal2/skyhanni/config/features/dungeon/SecretChimeConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/dungeon/SecretChimeConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonSecretChime.kt
Outdated
Show resolved
Hide resolved
- Added warning message for Open Link button in SecretChimeConfig.
7110af5
to
8d1d435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm, thank you!
Co-authored-by: Ovi <ovi2561@gmail.com> Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
What
Added a Secret Chime to dungeons with adjustable pitch and sound. Created a
ClickBlockType
enum for block types. Added aDungeonBlockClickEvent
class to manage dungeon block clicks and updatedDungeonHighlightClickedBlocks
to work with this new event class.Hopefully, I’ve fixed all the issues as requested.
I made a mistake in the previous pull request, so here is a new one and Im a new contributor.
Changelog New Features
Changelog Technical Details
ClickBlockType
enum and aDungeonBlockClickEvent
class. - Ovi_1DungeonHighlightClickedBlocks
to use the newDungeonBlockClickEvent
class. - Ovi_1