Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dungeon Secret Chime #2478

Merged
merged 5 commits into from
Sep 7, 2024
Merged

Conversation

Ovi-111
Copy link
Contributor

@Ovi-111 Ovi-111 commented Sep 7, 2024

What

Added a Secret Chime to dungeons with adjustable pitch and sound. Created a ClickBlockType enum for block types. Added a DungeonBlockClickEvent class to manage dungeon block clicks and updated DungeonHighlightClickedBlocks to work with this new event class.

Hopefully, I’ve fixed all the issues as requested.

I made a mistake in the previous pull request, so here is a new one and Im a new contributor.

Changelog New Features

  • Added a Secret Chime for Dungeons with adjustable pitch and sound. - Ovi_1
    • The sound and pitch of chimes in dungeons are customizable.

Changelog Technical Details

  • Created a ClickBlockType enum and a DungeonBlockClickEvent class. - Ovi_1
    • Added a new enum for block types and a class to handle click events on dungeon blocks.
  • Updated DungeonHighlightClickedBlocks to use the new DungeonBlockClickEvent class. - Ovi_1

- Improvement: Dungeon Highlight Clicked Blocks
@Thunderblade73
Copy link
Contributor

Changelog Improvements
Updated DungeonHighlightClickedBlocks to use the new DungeonBlockClickEvent class. - Ovi_1

This is a technical change. Not an improvements, since this is not a user side imporvement and everything dev related lands in the Technical Details.

@hannibal002
Copy link
Owner

This is a succession of #2453

@hannibal002 hannibal002 added this to the Version 0.27 milestone Sep 7, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Sep 7, 2024
- Added warning message for Open Link button in SecretChimeConfig.
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, thank you!

@hannibal002 hannibal002 enabled auto-merge (squash) September 7, 2024 18:41
@hannibal002 hannibal002 merged commit 2d2ba2a into hannibal002:beta Sep 7, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 7, 2024
MTOnline69 pushed a commit to MTOnline69/SkyHanni that referenced this pull request Sep 11, 2024
Co-authored-by: Ovi <ovi2561@gmail.com>
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants