Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Carnival QoL #2498

Merged
merged 13 commits into from
Sep 13, 2024
Merged

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Sep 11, 2024

What

Some needed QoL for Carnival. See Changelog for details.

Images

Changelog New Features

  • Added a Reminder to claim Carnival Tickets. - Thunderbalde73
  • Added display for Carnival Goals. - Thunderbalde73
  • Added a feature to double-click the Carnival NPC to start the game without clicking in the chat. - Thunderbalde73

@hannibal002 hannibal002 added this to the Version 0.27 milestone Sep 11, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Sep 11, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double click NPC works fine.

Have not noticed a daily ticket reminder message.

This looks wrong to me:
image

@Thunderblade73
Copy link
Contributor Author

Double click NPC works fine.

Have not noticed a daily ticket reminder message.

This looks wrong to me: image

There is the issue
image
(Wrong copy paste)

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fruit digging: Dragonfruit

image

§f    §r§f4x §r§aApple§r§f, §r§f3x §r§aMango§r§f, §r§f3x §r§9Watermelon§r§f, §r§f1x §r§5Cherry§r§f, §r§f2x §r§5Coconut§r§f,
§r§f                    §r§f1x §r§dDragonfruit§r§f, §r§f2x §r§cBomb§r§f, §r§f2x §r§eRum

@Thunderblade73
Copy link
Contributor Author

image

You already have it done. That's why there is no message for the complete of the goal from hypixel. This is intended behavior. Talk with Camilla to update your already completed goals. (Same for all other 2 issues)

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking to Chantelle updates the goals, yes

@hannibal002 hannibal002 merged commit 691d255 into hannibal002:beta Sep 13, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants