Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Carry Tracker Remove #2829

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Oct 26, 2024

What

Makes it so that you can actually remove people from the carry tracker

Changelog Improvements

  • Added the ability to remove people from the Carry Tracker. - Empa

@github-actions github-actions bot added the Bug Fix Bug fixes label Oct 26, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 26, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
change the changelog to improvement, and indicate that this now additionally to the gui also works via command

Copy link

One or more Detekt Failures were detected:

@ItsEmpa ItsEmpa changed the title Fix: Carry Tracker Remove Improvement: Carry Tracker Remove Oct 26, 2024
@github-actions github-actions bot added Wrong Title/Changelog There is an error in the title or changelog and removed Bug Fix Bug fixes labels Oct 26, 2024
Copy link

I have detected some issues with your pull request:

Title issues:
PR has category 'Improvement' which is not in the changelog. Expected categories: Fix

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 26, 2024
@ItsEmpa ItsEmpa requested a review from hannibal002 October 27, 2024 06:18
Copy link

One or more Detekt Failures were detected:

Copy link

One or more Detekt Failures were detected:

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Nov 1, 2024
@hannibal002 hannibal002 enabled auto-merge (squash) November 11, 2024 19:17
@github-actions github-actions bot added the Detekt Has detekt problem label Nov 11, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 11, 2024
@hannibal002 hannibal002 merged commit 5cd6e98 into hannibal002:beta Nov 11, 2024
6 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Nov 11, 2024
@ItsEmpa ItsEmpa deleted the fix/carry-remove branch November 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants