Fix: Itempickup log hay bale #2873
Open
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsEmpa
suggested changes
Nov 1, 2024
src/main/java/at/hannibal2/skyhanni/features/inventory/ItemPickupLog.kt
Outdated
Show resolved
Hide resolved
ItsEmpa
approved these changes
Nov 1, 2024
|
This bug also affects I had an open PR for this but I need to get around to finishing it. I don't remember if my implementation fixed it for item pickup log. |
hannibal002
requested changes
Nov 1, 2024
| val itemStack = (it.internalName.getItemStack()) | ||
|
|
||
| // TODO this should not need to be done here but the whole internal name resolving needs a rework and this fixes it for now | ||
| val internalName = if (it.internalName == HAY_BALE) HAY_BLOCK else it.internalName |
There was a problem hiding this comment.
code duplication of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
hay bale (wheat) is HAY_BLOCK but hay bale (furniture) gets HAY_BALE
when internal name gets resolved from the sack pickup message it incorrectly resolves to the wrong block.
this fixes it for itempickup log for now until the internalname system is changed with the removal of neu.
this fix works since there is no way for furniture to end up in the sack change message
Changelog Fixes