-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Remove asInternalName #2893
Conversation
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
the old function is deprecated and should still be deprecated for some time. there is no need for this pr to get merged now, as it will only break other prs. lets wait on this for couple more full versions, right? |
im fine with keeping the old method, but not merging it for some time because it could break other prs feels kinda weird. |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # detekt/baseline.xml
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay less deprecated spam, i still feel that the old method should be fully gone but 🤷, this will have to do
What
This Pull Request only replaces the old asInternalName() with the new toInternalName(), making the deprecated spam smaller (by a bit).
This will cause build failures on prs that don't use the new method yet, but honestly they shouldn't even use it anyway
Changelog Technical Details
asInternalName()
method. - j10a1n15