Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Remove asInternalName #2893

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Nov 4, 2024

What

This Pull Request only replaces the old asInternalName() with the new toInternalName(), making the deprecated spam smaller (by a bit).
This will cause build failures on prs that don't use the new method yet, but honestly they shouldn't even use it anyway

Changelog Technical Details

  • Removed the outdated asInternalName() method. - j10a1n15

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

I have detected some issues with your pull request:

Body issues:
Change should start with 'Removed' instead of 'Remove' in text: Remove outdated asInternalName() method.

Please fix these issues. For the correct format, refer to the pull request template.

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Nov 4, 2024
@hannibal002
Copy link
Owner

the old function is deprecated and should still be deprecated for some time. there is no need for this pr to get merged now, as it will only break other prs. lets wait on this for couple more full versions, right?

@j10a1n15
Copy link
Contributor Author

j10a1n15 commented Nov 4, 2024

the old function is deprecated and should still be deprecated for some time. there is no need for this pr to get merged now, as it will only break other prs. lets wait on this for couple more full versions, right?

im fine with keeping the old method, but not merging it for some time because it could break other prs feels kinda weird.
The only thing that got changed was the renaming of a method call, that could break like up to 1-2 prs that removed a function that had that call inside

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@hannibal002 hannibal002 added this to the Version 0.29 milestone Nov 5, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 11, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added Merge Conflicts There are open merge conflicts with the beta branch. and removed Merge Conflicts There are open merge conflicts with the beta branch. labels Nov 11, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 12, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay less deprecated spam, i still feel that the old method should be fully gone but 🤷, this will have to do

@CalMWolfs CalMWolfs enabled auto-merge (squash) November 12, 2024 11:51
@CalMWolfs CalMWolfs merged commit 2049030 into hannibal002:beta Nov 12, 2024
6 checks passed
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Nov 12, 2024
@CalMWolfs CalMWolfs modified the milestones: Version 0.29, Version 0.28 Nov 12, 2024
@j10a1n15 j10a1n15 deleted the backend/asInternalName branch November 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants