Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Garden Keybinds Crash #2969

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Nov 21, 2024

What

This PR fixes a crash related to custom garden keybinds.

Changelog Fixes

  • Fixed a crash caused by Custom Garden Keybinds. - Empa

Signed-off-by: Empa <itsempa@users.noreply.github.com>
@github-actions github-actions bot added the Bug Fix Bug fixes label Nov 21, 2024
Signed-off-by: Empa <itsempa@users.noreply.github.com>
@ItsEmpa
Copy link
Contributor Author

ItsEmpa commented Nov 21, 2024

also made it properly detect duplicate keybinds again

Copy link
Contributor

@DavidArthurCole DavidArthurCole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I noted in Discord (see https://discord.com/channels/997079228510117908/1094190239532208228/1309186201235755131), this fix seems to have inadvertently enabled chat-walking while holding farming tools.

Signed-off-by: Empa <itsempa@users.noreply.github.com>
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Nov 22, 2024
@hannibal002 hannibal002 self-requested a review November 23, 2024 11:41
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant reproduce the crash, but can confirm this works for me still

@hannibal002 hannibal002 merged commit 3d219af into hannibal002:beta Nov 23, 2024
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants