Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Graph Editor Directional Edge Support #2970

Merged

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Nov 21, 2024

What

The graph editor can now work with directional graphs.

The user side logic for pathfinding did always support directional graphs which can now be utilized.

Changelog Technical Details

  • Added directional edge support to Graph Editor. - Thunderblade73
  • Added Pyramid drawing. - Thunderblade73

@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Nov 21, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added Pyramid drawing

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Detekt Has detekt problem and removed Wrong Title/Changelog There is an error in the title or changelog labels Nov 21, 2024
Copy link

One or more Detekt Failures were detected:

  • GraphEditor.kt#L618: Line detected, which is longer than the defined maximum line length in the code style.

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 21, 2024
@Thunderblade73 Thunderblade73 marked this pull request as draft November 23, 2024 00:36
@Thunderblade73 Thunderblade73 marked this pull request as ready for review November 23, 2024 01:13
@github-actions github-actions bot added the Detekt Has detekt problem label Nov 23, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 23, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Nov 23, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Nov 23, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should throw an error in GraphEditorBugFinder

grafik

@hannibal002
Copy link
Owner

interestingly, this does throw an error, as intended
grafik

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 1, 2024
@hannibal002 hannibal002 self-requested a review December 2, 2024 21:45
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensively tested, works fine <3

@hannibal002 hannibal002 merged commit f5af23b into hannibal002:beta Dec 3, 2024
6 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants