Feature: Hitman Statistics #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
github-actions
bot
removed
the
Wrong Title/Changelog
One or more Detekt Failures were detected:
|
github-actions
bot
added
the
Merge Conflicts
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
One or more Detekt Failures were detected:
|
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
|
I keep getting donowalled trying to get someone to check my math here, so I'm assuming it's right, and this is ready, but it could very well be bugged 🔥 |
hannibal002
added
the
Soon
CalMWolfs
reviewed
Dec 10, 2024
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityAPI.kt
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Actually implements and populates the hitman statistics that were added to CF in the features branch, then got reverted before it was merged. I'm like 95% sure this is all functioning as intended, as I did some testing in my own profiles, but math is hard :(
Repackaged some of the hitman stuff into its own package under CF, since it seems like that will be the place for it moving forward.
Images
(Last 2 are broken in this image)
(This is what they'll actually be closer to)
Changelog New Features