Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement + Fix: Personal Bests Gain #2996

Merged
merged 19 commits into from
Nov 29, 2024
Merged

Improvement + Fix: Personal Bests Gain #2996

merged 19 commits into from
Nov 29, 2024

Conversation

Chissl
Copy link
Contributor

@Chissl Chissl commented Nov 27, 2024 •
edited by hannibal002
Loading

Dependencies

What

Fixes incorrect personal best gain calculations if new personal best is over the max pb, adds option to show overflow personal bests.

Changelog Improvements

  • Added overflow support for personal bests. - Chissl

Changelog Fixes

  • Fixed incorrect personal best gain calculations. - Chissl

@github-actions github-actions bot added the Bug Fix Bug fixes label Nov 27, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Nov 28, 2024
hannibal002
hannibal002 requested changes Nov 28, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You actually need to use the ConfigFixEvent in order to fix the event, not only bump the version nuber.

src/main/java/at/hannibal2/skyhanni/config/features/garden/PersonalBestsConfig.java Outdated Show resolved Hide resolved
@hannibal002
Copy link
Owner

Also you can optimize this here from left to right
image

Chissl and others added 2 commits November 29, 2024 00:32
@Chissl @CalMWolfs
fix typo
035bc41 
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@Chissl
rename pbIncrement to personalBestIncrements
664d510
@Chissl Chissl requested a review from CalMWolfs November 29, 2024 00:38
@hannibal002 hannibal002 enabled auto-merge (squash) November 29, 2024 09:40
@hannibal002 hannibal002 merged commit 030c373 into hannibal002:beta Nov 29, 2024
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Nov 29, 2024
@ptlthg ptlthg mentioned this pull request Dec 6, 2024
Merged
@Chissl Chissl deleted the pbFix branch December 7, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

@CalMWolfs CalMWolfs Awaiting requested review from CalMWolfs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
3 participants
@Chissl @hannibal002 @CalMWolfs