-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: AH estimated item value comparison #339
Conversation
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
This pull request has conflicts with the base branch. Please resolve those so we can evaluate the pull request. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt # src/main/java/at/hannibal2/skyhanni/features/inventory/ChestValue.kt # src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedItemValue.kt # src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedWardrobePrice.kt # src/main/java/at/hannibal2/skyhanni/utils/NumberUtil.kt
Conflicts have been resolved! 🎉 |
I have fixed this up so now it is usable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your changes look good, just changed the pattern slightly and used pattern groups
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com> Co-authored-by: Cal <cwolfson58@gmail.com>
What
Makes it easier to find good/bad items in ah compared to their estimated item value.
Images
Changelog New Features