Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: AH estimated item value comparison #339

Merged
merged 11 commits into from
Mar 14, 2024
Merged

Feature: AH estimated item value comparison #339

merged 11 commits into from
Mar 14, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jul 27, 2023

What

Makes it easier to find good/bad items in ah compared to their estimated item value.

Images

image
image

Changelog New Features

  • Added AH Show Price Comparison. - hannibal2
    • Highlight auctions based on the difference between their estimated value and the value they are listed for.
    • Options to change the colours

@hannibal002 hannibal002 changed the title init AH estimated item value comparison Jul 27, 2023
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 29, 2023
@github-actions
Copy link

This pull request has conflicts with the base branch. Please resolve those so we can evaluate the pull request.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
#	src/main/java/at/hannibal2/skyhanni/features/inventory/ChestValue.kt
#	src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedItemValue.kt
#	src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedWardrobePrice.kt
#	src/main/java/at/hannibal2/skyhanni/utils/NumberUtil.kt
Copy link

github-actions bot commented Mar 6, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 6, 2024
@CalMWolfs CalMWolfs marked this pull request as ready for review March 6, 2024 12:28
@CalMWolfs
Copy link
Collaborator

I have fixed this up so now it is usable.
Also does not feel very op or too powerful

@CalMWolfs CalMWolfs added this to the Version 0.24 milestone Mar 6, 2024
@hannibal002 hannibal002 added the Backend A backend pull request that will be merged soon label Mar 7, 2024
@CalMWolfs CalMWolfs added Soon This Pull Request will be merged within the next couple of betas and removed Backend A backend pull request that will be merged soon labels Mar 7, 2024
@hannibal002 hannibal002 changed the title AH estimated item value comparison Feature: AH estimated item value comparison Mar 13, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your changes look good, just changed the pattern slightly and used pattern groups

@hannibal002 hannibal002 merged commit 578069c into beta Mar 14, 2024
7 checks passed
@hannibal002 hannibal002 deleted the ah_item_value branch March 14, 2024 11:18
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Mar 14, 2024
Thunderblade73 pushed a commit to Thunderblade73/SkyHanni that referenced this pull request Mar 15, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Co-authored-by: Cal <cwolfson58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants