Feature: Shadow Assassin Jump Notification #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/features/FishingConfig.java # src/main/java/at/hannibal2/skyhanni/features/fishing/BarnFishingTimer.kt
nea89o
suggested changes
Jan 16, 2024
src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonShadowAssassinNotification.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonShadowAssassinNotification.kt
Outdated
Show resolved
Hide resolved
…adowAssassinNotification.kt Co-authored-by: Linnea Gräf <nea@nea.moe>
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
hannibal002
changed the title
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
CalMWolfs
added
the
Soon
|
Just pushed some code cleanup, feature worked well but i did not test in any boss fights so it could false trigger there |
CalMWolfs
approved these changes
Apr 5, 2024
hannibal002
changed the title
hannibal002
requested changes
Apr 5, 2024
src/main/java/at/hannibal2/skyhanni/config/features/dungeon/DungeonConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonShadowAssassinNotification.kt
Outdated
Show resolved
Hide resolved
CalMWolfs
approved these changes
Apr 5, 2024
hannibal002
approved these changes
Apr 5, 2024
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature alerts you when a Shadow Assassin is about to jump on you (especially good for noobs like me who die in mm to a lot of shadow assassins)
Changelog New Features