Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run export-validator on Windows #1342

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

MartinKavik
Copy link
Contributor

Add export-validator Windows support.

Fixes #1231

Tested with just build on Windows 10 and Kubuntu 22.04 local machines.


Note:
To make just build work on Windows I had to install Visual Studio with clang and then MinGW with ar and add both tools to PATH env var to make cross-compiler work.
On Linux, I had to install libfontconfig-dev and clang.

Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MartinKavik! Looks reasonable, and the CI build is green. Good to merge 👍

Note:
To make just build work on Windows I had to install Visual Studio with clang and then MinGW with ar and add both tools to PATH env var to make cross-compiler work.
On Linux, I had to install libfontconfig-dev and clang.

Something like this should probably go into CONTRIBUTING.md. I've made a note about that, and plan to take care it next week (either by doing that, or by opening an issue).

@hannobraun hannobraun merged commit 873401c into hannobraun:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export-validator does not support Windows
2 participants