Continue cleanup of partial object API #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is no longer required, as `PartialCycle` makes sure that all surfaces are properly propagated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request starts implementing two ideas from #1249: The partial object merge infrastructure, and raising the level of abstraction of the partial object API.
This isn't a slam dunk, unfortunately. The merge infrastructure is not overly large or complicated, but it adds additional lines of code without (yet) saving that many. Raising the level of abstraction (only really realized for
PartialCycle, so far) has so far been a small net gain in lines of code.I think it's still a win though.
PartialCycleis now really hard to misuse, and the code used to achieve that is relatively obvious. On the other hand, I was able to remove some less obvious code as a result. It's also quite hard to find code that can be removed or simplified because of this, so I'm hopeful there are more gains waiting.Overall a step in the right direction, probably 😄