Simplify Store
#1384
Merged
Simplify Store
#1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't make a difference right now, due to the current usage patterns. But if those usage patterns were to change, and reserved slots would no longer be filled immediately, then the iterator would keep working, thanks to this change.
It's not used currently, and I'm about to replace it with something simpler.
It's not used there yet, but it will be soon, in a follow-up commit.
This method doesn't make much sense in isolation. This is just me breaking up what would be a rather large commit into smaller pieces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the insert and reserve operations into a single code path. This makes the implementation of
Storesimpler, at the cost of making its use a bit more complicated. I think this is a good trade-off, for two reasons:Storeonly indirectly throughInsert(Make use ofInserttrait pervasively #1377 recently completed this migration).Despite the simplification, we unfortunately end up with more code here, due to lots of repetitive code in the
Storewrappers. I believe that the prototyping work I mentioned above will result in those wrappers to become simpler, removing all that repetitive code, so I'm fine with that too.