Fix camera rotation around focus point #644
Conversation
There was a problem hiding this comment.
Thank you @chrisprice, looks and works great!
The larger the rotation, the less intuitive the axis of rotation becomes. This is due to it being fixed to x/y axis rather than relative to
Camerarotation.
Good point! Feel free to open an issue about that. If not, I can do it myself (already made a note, will do it once I get to it).
Whilst the transform in
Camerais broken intorotationandtranslationmatrices, the current implementation ofRotationdoes not guaranteerotationis an orthogonal matrix (under heading Properties of the Transform Matrix).
That looks like an interesting article! Unfortunately I don't have the time to read it completely right now, so I don't quite follow why this lack of orthogonality is a problem. But I'd just like to emphasize that the way that code is written isn't very intentional (beyond trying to get a certain result), so further improvements are certainly welcome.
| @@ -43,7 +43,7 @@ impl Rotation { | |||
|
|
|||
| let inv = trans.inverse(); | |||
|
|
|||
| camera.rotation = trans * rot_y * rot_x * inv * camera.rotation; | |||
| camera.rotation = camera.rotation * trans * rot_y * rot_x * inv; | |||
There was a problem hiding this comment.
Oh man, these kinds of fixes are the best. One line changed, but probably took many hours to figure out 😂
This fixes the remaining part of #18.
I've noticed a couple of possible further issues -
Camerarotation.Camerais broken intorotationandtranslationmatrices, the current implementation ofRotationdoes not guaranteerotationis an orthogonal matrix (under heading Properties of the Transform Matrix).edit by @hannobraun:
Close #18 (to make sure the issue is closed when this PR is merged)