Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate around axis relative to camera #669

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

chrisprice
Copy link
Contributor

Fixes #658.

Disclaimers 😄

  • I've opted for a relatively lightweight change. I can think of more intrusive changes which extend the types around Transform but didn't want to jump into that without discussion.
  • I'm also not an expert in this area, I've just been following through this article. There are likely to be mathematical simplifications that I've missed.
  • I've noticed discussion about removing the dependency on nalgebra so I haven't dug into its API looking for appropriate implementations of the logic I've added. There's very likely to be something in there that I've missed.

@chrisprice chrisprice requested a review from hannobraun as a code owner June 5, 2022 10:15
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @chrisprice, this works great!

Sorry for the delay in reviewing this. Monday was a public holiday here in Germany, and I spent most of it away from the computer.

@hannobraun hannobraun merged commit 9dc8d43 into hannobraun:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotation axis should be more intuitive
2 participants