Support Renderer-API, support Indoor-Navigation API #99

hansemannn · 2017-07-13T18:10:03Z

Support the Renderer API (Add support for KML/GeoJSON #98)
Support the full IndoorNavigation API

hansemannn · 2017-07-15T05:20:53Z

@yozef wanna review? 👀 😃

yozef · 2017-07-15T12:16:42Z

Sure :)

yozef · 2017-07-15T12:54:12Z

Having crashes when I use:

// Testing 3.8.0
$.mapview.indoorPicker = true;
$.mapview.indoorEnabled = true;
	
$.mapview.indoorDisplay.addEventListener('didChangeActiveBuilding', function(e) {
	Ti.API.info('didChangeActiveBuilding ' + JSON.stringify(e));
});
$.mapview.indoorDisplay.addEventListener('didChangeActiveLevel', function(e) {
	Ti.API.info('didChangeActiveLevel ' + JSON.stringify(e));
});

When I zoom into an area where I know has indoor location, zooming in enough just when the events are about to fire, I get this uncaught exception:

[ERROR] :  The application has crashed with an uncaught exception 'NSInvalidArgumentException'.
[ERROR] :  Reason:
[ERROR] :  -[TiGooglemapsIndoorLevelProxy copyWithZone:]: unrecognized selector sent to instance 0x7fb34c755a80
[ERROR] :  Stack trace: ...

yozef · 2017-07-15T12:58:34Z

Testing out the KML renderer:

// Render KML
var renderer = $.mapview.createRenderer({
    file: 'KML_Samples.kml',  // added this .kml into assets/
    mapView: $.mapview
});
renderer.render();

I get this error:
[ERROR] : message = "undefined is not a function (evaluating '$.mapview.createRenderer({\n file: \"KML_Samples.kml\",\n mapView: $.mapview\n })')";

It seems that this might be on my end? maybe wrong API implementation (I used the same code syntax from the readme).

Using this KML: https://developers.google.com/kml/documentation/KML_Samples.kml

hansemannn · 2017-07-15T16:28:51Z

Re indoor-picker: The floor name / floor short-name can be null, I added the guards now.
Re renderer: The renderer is created from the module-instance, not the map-view instance. It shouldn't crash then.

yozef · 2017-07-16T14:02:11Z

Re-tested indoor events with the new committed code (got the same result as before):
Crashes when I use:

// Testing 3.8.0
$.mapview.indoorPicker = true;
$.mapview.indoorEnabled = true;
	
$.mapview.indoorDisplay.addEventListener('didChangeActiveBuilding', function(e) {
	Ti.API.info('didChangeActiveBuilding ' + JSON.stringify(e));
});
$.mapview.indoorDisplay.addEventListener('didChangeActiveLevel', function(e) {
	Ti.API.info('didChangeActiveLevel ' + JSON.stringify(e));
});

When I zoom into an area where I know has indoor location, zooming in enough just when the events are about to fire, I get this uncaught exception:

[ERROR] :  The application has crashed with an uncaught exception 'NSInvalidArgumentException'.
[ERROR] :  Reason:
[ERROR] :  -[TiGooglemapsIndoorLevelProxy copyWithZone:]: unrecognized selector sent to instance 0x7faf3c4ca540
[ERROR] :  Stack trace:
[ERROR] :  0   CoreFoundation                      0x000000010b450af3 __exceptionPreprocess + 147
[ERROR] :  1   libobjc.A.dylib                     0x0000000105f0e141 objc_exception_throw + 48
[ERROR] :  2   CoreFoundation                      0x000000010b4c0134 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
[ERROR] :  3   CoreFoundation                      0x000000010b3d7840 ___forwarding___ + 1024
[ERROR] :  4   CoreFoundation                      0x000000010b3d73b8 _CF_forwarding_prep_0 + 120
[ERROR] :  5   MyApp                              0x00000001034801f0 TiBindingEventCreateWithNSObjects + 144
[ERROR] :  6   MyApp                              0x00000001032f9358 -[TiProxy fireEvent:withObject:propagate:reportSuccess:errorCode:message:] + 120
[ERROR] :  7   MyApp                              0x00000001032f8fdb -[TiProxy fireEvent:withObject:] + 139
[ERROR] :  8   MyApp                              0x0000000103ae760e -[TiGooglemapsIndoorDisplayProxy didChangeActiveLevel:] + 152
[ERROR] :  9   CoreFoundation                      0x000000010b3d8c6c __invoking___ + 140
[ERROR] :  10  CoreFoundation                      0x000000010b3d8b40 -[NSInvocation invoke] + 320
[ERROR] :  11  CoreFoundation                      0x000000010b3f0956 -[NSInvocation invokeWithTarget:] + 54
[ERROR] :  12  MyApp                              0x000000010354b6ce -[GMSDelegateForward forwardInvocation:] + 102
[ERROR] :  13  CoreFoundation                      0x000000010b3d7656 ___forwarding___ + 534
[ERROR] :  14  CoreFoundation                      0x000000010b3d73b8 _CF_forwarding_prep_0 + 120
[ERROR] :  15  MyApp                              0x000000010354bd6c -[GMSIndoorDisplay updateFocusedBuilding:activeLevel:indoorState:] + 259
[ERROR] :  16  MyApp                              0x00000001034bd0fc -[GMSMapView vectorMapView:didUpdateFocusedBuilding:fromBuilding:activeLevel:] + 127
[ERROR] :  17  MyApp                              0x000000010362fa7e -[GMSVectorMapView didUpdateFocusedBuilding:fromBuilding:activeLevel:] + 124
[ERROR] :  18  MyApp                              0x000000010369bed1 __44-[GMSIndoorFocusManager setFocusedBuilding:]_block_invoke + 57
[ERROR] :  19  libdispatch.dylib                   0x000000010cffb585 _dispatch_call_block_and_release + 12
[ERROR] :  20  libdispatch.dylib                   0x000000010d01c792 _dispatch_client_callout + 8
[ERROR] :  21  libdispatch.dylib                   0x000000010d004247 _dispatch_main_queue_callback_4CF + 1041
[ERROR] :  22  CoreFoundation                      0x000000010b415909 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
[ERROR] :  23  CoreFoundation                      0x000000010b3dbae4 __CFRunLoopRun + 2164
[ERROR] :  24  CoreFoundation                      0x000000010b3db016 CFRunLoopRunSpecific + 406
[ERROR] :  25  GraphicsServices                    0x000000010e4baa24 GSEventRunModal + 62
[ERROR] :  26  UIKit                               0x0000000107f1b134 UIApplicationMain + 159
[ERROR] :  27  MyApp                              0x0000000103213fc4 main + 100
[ERROR] :  28  libdyld.dylib                       0x000000010d06565d start + 1
[ERROR] :  29  ???                                 0x0000000000000001 0x0 + 1
-- End simulator log ---------------------------------------------------------

You can check at SFO airport Terminal 2: 37.617174, -122.383633 zoom in enough I got the results above.

yozef · 2017-07-16T14:10:25Z

KML renderer worked :)
I figured my code was the culprit before.

mcongrove · 2017-07-17T10:34:51Z

KML renderer definitely works; quite well, too! Thanks Hans.

mcongrove · 2017-07-17T10:46:04Z

The mapStyle no longer functions as it did before (tried passing JSON string, as well as new file location option). Get the following error: Could not apply map style: The data couldn't be read because it isn't in the correct format. Worked prior to this PR.

Sample styling JSON attached, generated from Google's style generator.

map_style.json.txt

yozef · 2017-07-17T11:27:59Z

@mcongrove hmmm style json is working for me. Not sure it's visible, but the KML snapshots posted have a json style rendered.

mcongrove · 2017-07-17T11:35:44Z

@yozef Strange. I went back to before 06e3d4d and my style JSON works. Any newer commit and it breaks for me. Sanity check me by trying my JSON file?

yozef · 2017-07-17T11:45:54Z

@mcongrove this requires a different issue to be opened, as the indoor events are still buggy.

For the mapStyle:

var mapJSONStyle = [ { "elementType": "geometry", "stylers": [ { "color": "#ebe3cd" } ] } ..... ]; // Array Obj
$.mapview.mapStyle = JSON.stringify(mapJSONStyle);

hansemannn · 2017-07-17T14:58:59Z

@mcongrove I changed the mapStyle to detect both JSON-strings and file-references. If it's a JSON-file, it needs to end with ".json", if it's any other string, it will be passed to the module.

mcongrove · 2017-07-17T15:00:15Z

@hansemannn It does end in ".json"; GitHub just doesn't allow that file extension for uploads, so I used ".txt". Sorry, should've clarified that.

hansemannn · 2017-07-17T15:12:16Z

Can you try the latest commit? I forgot commiting yesterday :-)

mcongrove · 2017-07-17T15:31:49Z

I'm confused. Looks like the only changes since the last version I tested is to the README. What are you wanting me to re-test?

hansemannn · 2017-07-23T15:30:21Z

@mcongrove Dump issue, fixed it.

hansemannn · 2017-07-23T15:54:46Z

@yozef Working on the indoor-level issue, it's related to the GoogleMaps SDK not being thread-safe again :(

hansemannn · 2017-07-26T14:20:14Z

I've created a ticket at Google for this, since I'm kind of running out of ideas here, what the SDK could do wrong. Maybe we exclude that event for now and mark it as a future support? Would be bad to block all the other features here because of that one.

hansemannn · 2017-07-26T14:30:17Z

Fixed it.....Let's get this in @yozef 😅

yozef · 2017-07-26T16:37:10Z

Hey Hans, I'm actually on vacation. No computer around :-/

…

On Wed, Jul 26, 2017 at 17:30 Hans Knöchel ***@***.***> wrote: Fixed it.....Let's get this in @yozef <https://github.com/yozef> 😅 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#99 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARiGA49_fqV5mPgQiZ57m6NG7kQrPVeks5sR015gaJpZM4OXWfW> .

Support Renderer-API, support Indoor-Navigation API

Add map-renderer

24fc11b

hansemannn added this to the v3.8.0 milestone Jul 13, 2017

hansemannn changed the title ~~Add map-renderer~~ Add "renderFromFile" method Jul 13, 2017

hansemannn mentioned this pull request Jul 13, 2017

Add support for KML/GeoJSON #98

Closed

hansemannn added 3 commits July 13, 2017 11:40

Add renderer-examples

26ed8b6

Update README with renderer-example

ee0591f

Update renderer API

c6e9f01

hansemannn self-assigned this Jul 14, 2017

hansemannn changed the title ~~Add "renderFromFile" method~~ Add Renderer-API Jul 14, 2017

hansemannn changed the title ~~Add Renderer-API~~ Support Renderer-API, support Indoor-Navigation API Jul 15, 2017

hansemannn added 2 commits July 14, 2017 22:11

Add support for indoor-navigation

9bd7f1f

Add indoor-navigation docs

33a3e7d

Improve map-style to also allow json-path

06e3d4d

hansemannn requested a review from yozef July 15, 2017 16:21

Guard nil in indoor-level

d1444ad

Add missing code-docs, rename some attributes

5850faa

hansemannn added the feature label Jul 15, 2017

hansemannn and others added 2 commits July 17, 2017 08:10

Update README.md

5c8107c

Improve map-style to also allow json-path

49b5348

hansemannn and others added 2 commits July 23, 2017 08:25

Merge branch 'master' into add-renderer

aea5eef

Fix dump extension-error

1ea9970

Fix main-thread execution

7507d07

Fix my dump error!

26c7a94

hansemannn merged commit d333beb into master Jul 28, 2017

hansemannn deleted the add-renderer branch October 26, 2017 16:56

hansemannn added a commit that referenced this pull request Nov 12, 2020

Merge pull request #99 from hansemannn/add-renderer

4cd8955

Support Renderer-API, support Indoor-Navigation API

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Renderer-API, support Indoor-Navigation API #99

Support Renderer-API, support Indoor-Navigation API #99

hansemannn commented Jul 13, 2017 •

edited

Loading

hansemannn commented Jul 15, 2017

yozef commented Jul 15, 2017 •

edited

Loading

yozef commented Jul 15, 2017

yozef commented Jul 15, 2017 •

edited

Loading

hansemannn commented Jul 15, 2017

yozef commented Jul 16, 2017 •

edited

Loading

yozef commented Jul 16, 2017 •

edited

Loading

mcongrove commented Jul 17, 2017

mcongrove commented Jul 17, 2017

yozef commented Jul 17, 2017

mcongrove commented Jul 17, 2017 •

edited

Loading

yozef commented Jul 17, 2017 •

edited

Loading

hansemannn commented Jul 17, 2017

mcongrove commented Jul 17, 2017

hansemannn commented Jul 17, 2017

mcongrove commented Jul 17, 2017

hansemannn commented Jul 23, 2017

hansemannn commented Jul 23, 2017

hansemannn commented Jul 26, 2017 •

edited

Loading

hansemannn commented Jul 26, 2017

yozef commented Jul 26, 2017 via email

Support Renderer-API, support Indoor-Navigation API #99

Support Renderer-API, support Indoor-Navigation API #99

Conversation

hansemannn commented Jul 13, 2017 • edited Loading

hansemannn commented Jul 15, 2017

yozef commented Jul 15, 2017 • edited Loading

yozef commented Jul 15, 2017

yozef commented Jul 15, 2017 • edited Loading

hansemannn commented Jul 15, 2017

yozef commented Jul 16, 2017 • edited Loading

yozef commented Jul 16, 2017 • edited Loading

mcongrove commented Jul 17, 2017

mcongrove commented Jul 17, 2017

yozef commented Jul 17, 2017

mcongrove commented Jul 17, 2017 • edited Loading

yozef commented Jul 17, 2017 • edited Loading

hansemannn commented Jul 17, 2017

mcongrove commented Jul 17, 2017

hansemannn commented Jul 17, 2017

mcongrove commented Jul 17, 2017

hansemannn commented Jul 23, 2017

hansemannn commented Jul 23, 2017

hansemannn commented Jul 26, 2017 • edited Loading

hansemannn commented Jul 26, 2017

yozef commented Jul 26, 2017 via email

hansemannn commented Jul 13, 2017 •

edited

Loading

yozef commented Jul 15, 2017 •

edited

Loading

yozef commented Jul 15, 2017 •

edited

Loading

yozef commented Jul 16, 2017 •

edited

Loading

yozef commented Jul 16, 2017 •

edited

Loading

mcongrove commented Jul 17, 2017 •

edited

Loading

yozef commented Jul 17, 2017 •

edited

Loading

hansemannn commented Jul 26, 2017 •

edited

Loading