fix: page index evaluator min/max args inverted (apache#648)

* fix: page index evaluator min/max args inverted * style: fix clippy lint in test
hansetag · Sep 30, 2024 · af9609d · af9609d
1 parent a6a3fd7
commit af9609d
Show file tree

Hide file tree

Showing 3 changed files with 221 additions and 27 deletions.
diff --git a/crates/iceberg/src/expr/visitors/page_index_evaluator.rs b/crates/iceberg/src/expr/visitors/page_index_evaluator.rs
@@ -246,10 +246,10 @@ impl<'a> PageIndexEvaluator<'a> {
                 .zip(row_counts.iter())
                 .map(|(item, &row_count)| {
                     predicate(
-                        item.max.map(|val| {
+                        item.min.map(|val| {
                             Datum::new(field_type.clone(), PrimitiveLiteral::Boolean(val))
                         }),
-                        item.min.map(|val| {
+                        item.max.map(|val| {
                             Datum::new(field_type.clone(), PrimitiveLiteral::Boolean(val))
                         }),
                         PageNullCount::from_row_and_null_counts(row_count, item.null_count),
@@ -262,10 +262,10 @@ impl<'a> PageIndexEvaluator<'a> {
                 .zip(row_counts.iter())
                 .map(|(item, &row_count)| {
                     predicate(
-                        item.max
-                            .map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Int(val))),
                         item.min
                             .map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Int(val))),
+                        item.max
+                            .map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Int(val))),
                         PageNullCount::from_row_and_null_counts(row_count, item.null_count),
                     )
                 })
@@ -276,10 +276,10 @@ impl<'a> PageIndexEvaluator<'a> {
                 .zip(row_counts.iter())
                 .map(|(item, &row_count)| {
                     predicate(
-                        item.max
-                            .map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Long(val))),
                         item.min
                             .map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Long(val))),
+                        item.max
+                            .map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Long(val))),
                         PageNullCount::from_row_and_null_counts(row_count, item.null_count),
                     )
                 })
@@ -312,13 +312,13 @@ impl<'a> PageIndexEvaluator<'a> {
                 .zip(row_counts.iter())
                 .map(|(item, &row_count)| {
                     predicate(
-                        item.max.map(|val| {
+                        item.min.map(|val| {
                             Datum::new(
                                 field_type.clone(),
                                 PrimitiveLiteral::Double(OrderedFloat::from(val)),
                             )
                         }),
-                        item.min.map(|val| {
+                        item.max.map(|val| {
                             Datum::new(
                                 field_type.clone(),
                                 PrimitiveLiteral::Double(OrderedFloat::from(val)),