Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for hapi 18 #204

Closed
kanongil opened this issue Jan 21, 2019 · 2 comments · Fixed by #205
Closed

Update for hapi 18 #204

kanongil opened this issue Jan 21, 2019 · 2 comments · Fixed by #205
Assignees
@hueniverse
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Milestone
10.0.0

Comments

@kanongil
Copy link

It needs to handle URL objects:
https://github.com/hapijs/hapi-auth-cookie/blob/cb8796f9c7f22fd8af10adf3563a5f702ad57e25/lib/index.js#L233
@kanongil kanongil mentioned this issue Jan 21, 2019
Closed
@rluba rluba mentioned this issue Feb 19, 2019
Merged
@PazzaVlad
Copy link
Contributor

PazzaVlad commented Mar 5, 2019 •
edited
Loading

So this module doesn't work with Hapi 18?

edited: works well for me with hapi 18.1

@hueniverse hueniverse self-assigned this Mar 15, 2019
@hueniverse hueniverse added dependency Update module dependency breaking changes Change that can breaking existing code labels Mar 15, 2019
@hueniverse hueniverse added this to the 9.1.1 milestone Mar 15, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Upgrade to hapi 18 rluba/hapi-auth-cookie
3 participants
@hueniverse @kanongil @PazzaVlad