Clone without prototype. Closes #290

hapijs · Mar 27, 2019 · f2eb7fd · f2eb7fd
1 parent 5bfe5b6
commit f2eb7fd
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 5 deletions.
diff --git a/.vs/VSWorkspaceState.json b/.vs/VSWorkspaceState.json
@@ -0,0 +1,9 @@
+{
+  "ExpandedNodes": [
+    "",
+    "\\lib",
+    "\\test"
+  ],
+  "SelectedNode": "\\lib\\deep-equal.js",
+  "PreviewInSolutionExplorer": false
+}
diff --git a/.vs/hoek/v16/.suo b/.vs/hoek/v16/.suo
diff --git a/.vs/slnx.sqlite b/.vs/slnx.sqlite
diff --git a/lib/index.js b/lib/index.js
@@ -52,14 +52,20 @@ exports.clone = function (obj, options = {}, _seen = null) {
             newObj = new RegExp(obj);
         }
         else {
-            const proto = Object.getPrototypeOf(obj);
-            if (proto &&
-                proto.isImmutable) {
+            if (options.prototype !== false) {          // Defaults to true
+                const proto = Object.getPrototypeOf(obj);
+                if (proto &&
+                    proto.isImmutable) {
 
-                newObj = obj;
+                    newObj = obj;
+                }
+                else {
+                    newObj = Object.create(proto);
+                    cloneDeep = true;
+                }
             }
             else {
-                newObj = Object.create(proto);
+                newObj = {};
                 cloneDeep = true;
             }
         }

diff --git a/test/index.js b/test/index.js
@@ -247,6 +247,30 @@ describe('clone()', () => {
         expect(a).to.equal(b);
     });
 
+    it('clones an object without a prototype', () => {
+
+        const Obj = function () {
+
+            this.a = 5;
+        };
+
+        Obj.prototype.b = function () {
+
+            return 'c';
+        };
+
+        const a = new Obj();
+        a.x = 123;
+
+        const b = Hoek.clone(a, { prototype: false });
+
+        expect(a).to.equal(b);
+        expect(a).to.not.equal(b, { prototype: true });
+        expect(b.a).to.equal(5);
+        expect(b.b).to.not.exist();
+        expect(b.x).to.equal(123);
+    });
+
     it('reuses cloned Date object', () => {
 
         const obj = {