Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not confuse booleans for alernatives in strict mode #2850

Closed
wants to merge 1 commit into from
Closed

fix: do not confuse booleans for alernatives in strict mode #2850

wants to merge 1 commit into from

Conversation

Marsup
Copy link
Collaborator

@Marsup Marsup commented Sep 28, 2022

Fixes #2848

@Marsup Marsup added bug Bug or defect types TypeScript type definitions labels Sep 28, 2022
@Marsup Marsup added this to the 17.6.2 milestone Sep 28, 2022
@Marsup Marsup self-assigned this Sep 28, 2022
@Marsup Marsup mentioned this pull request Sep 28, 2022
Closed
@Marsup Marsup marked this pull request as draft September 29, 2022 07:01
@Marsup Marsup marked this pull request as ready for review September 29, 2022 07:08
Nargonath
Nargonath approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One question though for my own understanding, is the second generic parameter U used to keep the original value of T since T will be narrowed down by the conditional type so we can compare T to its original value after it's been narrowed?

@joshkel joshkel mentioned this pull request Sep 29, 2022
Merged
@Marsup
Copy link
Collaborator Author

Marsup commented Sep 29, 2022

Explanation is in https://stackoverflow.com/a/59687759.

Closing in favor of #2851.

@Marsup Marsup closed this Sep 29, 2022
@Marsup Marsup deleted the fix/strict-boolean branch September 29, 2022 16:04
@Nargonath
Copy link
Member

Thanks @Marsup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nargonath Nargonath Nargonath approved these changes

Assignees

@Marsup Marsup

Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Milestone
17.6.2
Development

Successfully merging this pull request may close these issues.

Strict object schema with a boolean property expects alternative, not boolean
2 participants
@Marsup @Nargonath