Return negative colorDiff if pixel is darker #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am implementing antialiasing detection in our comparison service and I need to be able to determine if the pixel is darker or lighter. We can encode this information by using a negative number if the pixel is darker, and a positive number if the pixel is lighter. We don't need this information in other places, so we can use Math.abs to normalize.
While I was at it, I switched getDiffPixel over to use colorDeltaChannels, since colorDelta is deprecated for performance reasons.