Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.7.2] Liquid vesting module #275

Merged
merged 32 commits into from
Feb 12, 2024
Merged

[v1.7.2] Liquid vesting module #275

merged 32 commits into from
Feb 12, 2024

Conversation

ivanovpetr
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024 •
edited
Loading

Codecov Report

Attention: 222 lines in your changes are missing coverage. Please review.

Comparison is base (20dfe01) 67.83% compared to head (d465caf) 67.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   67.83%   67.52%   -0.31%     
==========================================
  Files         200      212      +12     
  Lines       16155    16673     +518     
==========================================
+ Hits        10958    11259     +301     
- Misses       4661     4853     +192     
- Partials      536      561      +25
Files Coverage Δ
tests/e2e/upgrade/manager.go 0.00% <ø> (ø)
x/liquidvesting/keeper/keeper.go 100.00% <100.00%> (ø)
x/liquidvesting/keeper/params.go 100.00% <100.00%> (ø)
x/liquidvesting/types/denom.go 100.00% <100.00%> (ø)
x/liquidvesting/types/schedule.go 100.00% <100.00%> (ø)
x/vesting/keeper/msg_server.go 86.00% <100.00%> (-0.52%) ⬇️
x/liquidvesting/keeper/denom.go 93.33% <93.33%> (ø)
x/vesting/keeper/schedule.go 92.53% <92.53%> (ø)
app/app.go 82.88% <73.91%> (-0.27%) ⬇️
x/liquidvesting/types/codec.go 0.00% <0.00%> (ø)
... and 6 more

@ivanovpetr ivanovpetr marked this pull request as draft January 12, 2024 09:11
@ivanovpetr ivanovpetr marked this pull request as ready for review February 5, 2024 09:09
Yurist-85
Yurist-85 requested changes Feb 5, 2024
View reviewed changes
proto/haqq/liquidvesting/v1/liquidvesting.proto Outdated Show resolved Hide resolved
x/liquidvesting/handler.go Outdated Show resolved Hide resolved
x/liquidvesting/keeper/denom.go Outdated Show resolved Hide resolved
x/liquidvesting/keeper/denom.go Outdated Show resolved Hide resolved
x/liquidvesting/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/liquidvesting/types/schedule.go Outdated Show resolved Hide resolved
x/liquidvesting/types/errors.go Show resolved Hide resolved
x/liquidvesting/types/keys.go Outdated Show resolved Hide resolved
x/liquidvesting/types/keys.go Outdated Show resolved Hide resolved
x/liquidvesting/types/keys.go Outdated Show resolved Hide resolved
kioqq
kioqq requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@kioqq kioqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes

kioqq
kioqq requested changes Feb 12, 2024
View reviewed changes
x/liquidvesting/types/params.go Outdated Show resolved Hide resolved
@kioqq kioqq requested a review from onsails February 12, 2024 17:35
VorobevSA
VorobevSA reviewed Feb 12, 2024
View reviewed changes
Copy link

@VorobevSA VorobevSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok

@kodiakhq kodiakhq bot merged commit 1e0f366 into master Feb 12, 2024
14 checks passed
@kodiakhq kodiakhq bot deleted the liquid-vesting branch February 12, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kioqq kioqq kioqq approved these changes

@Yurist-85 Yurist-85 Yurist-85 approved these changes

@VorobevSA VorobevSA VorobevSA approved these changes

@onsails onsails Awaiting requested review from onsails onsails is a code owner

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivanovpetr @codecov-commenter @kioqq @Yurist-85 @VorobevSA