Move some chromium specific tests (#1019)

hardkoded · Mar 17, 2019 · 2ef86e3 · 2ef86e3
1 parent 26af946
commit 2ef86e3
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 26 deletions.
diff --git a/...ficLauncherTests/BrowserUrlOptionTests.cs → ...iumSpecificTests/BrowserUrlOptionTests.cs b/...ficLauncherTests/BrowserUrlOptionTests.cs → ...iumSpecificTests/BrowserUrlOptionTests.cs
@@ -2,7 +2,7 @@
 using Xunit;
 using Xunit.Abstractions;
 
-namespace PuppeteerSharp.Tests.ConnectionsTests
+namespace PuppeteerSharp.Tests.ChromiumSpecificTests
 {
     [Collection("PuppeteerLoaderFixture collection")]
     public class BrowserUrlOptionTests : PuppeteerPageBaseTest

diff --git a/lib/PuppeteerSharp.Tests/ChromiumSpecificTests/PageTests.cs b/lib/PuppeteerSharp.Tests/ChromiumSpecificTests/PageTests.cs
@@ -0,0 +1,40 @@
+using System.Threading.Tasks;
+using Microsoft.AspNetCore.Http;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace PuppeteerSharp.Tests.ChromiumSpecificTests
+{
+    [Collection("PuppeteerLoaderFixture collection")]
+    public class PageTests : PuppeteerPageBaseTest
+    {
+        public PageTests(ITestOutputHelper output) : base(output)
+        {
+        }
+
+        [Fact]
+        public async Task ShouldWorkWithInterventionHeaders()
+        {
+            Server.SetRoute("/intervention", context => context.Response.WriteAsync($@"
+              <script>
+                document.write('<script src=""{TestConstants.CrossProcessHttpPrefix}/intervention.js"">' + '</scr' + 'ipt>');
+              </script>
+            "));
+            Server.SetRedirect("/intervention.js", "/redirect.js");
+
+            string interventionHeader = null;
+            Server.SetRoute("/redirect.js", context =>
+            {
+                interventionHeader = context.Request.Headers["intervention"];
+                return context.Response.WriteAsync("console.log(1);");
+            });
+
+            await Page.SetRequestInterceptionAsync(true);
+            Page.Request += async (sender, e) => await e.Request.ContinueAsync();
+
+            await Page.GoToAsync(TestConstants.ServerUrl + "/intervention");
+
+            Assert.Contains("www.chromestatus.com", interventionHeader);
+        }
+    }
+}
diff --git a/lib/PuppeteerSharp.Tests/PageTests/SetRequestInterceptionTests.cs b/lib/PuppeteerSharp.Tests/PageTests/SetRequestInterceptionTests.cs
@@ -47,31 +47,6 @@ public async Task ShouldIntercept()
             Assert.Equal(TestConstants.Port, response.RemoteAddress.Port);
         }
 
-        [Fact]
-        public async Task ShouldWorkWithInterventionHeaders()
-        {
-            Server.SetRoute("/intervention", context => context.Response.WriteAsync($@"
-              <script>
-                document.write('<script src=""{TestConstants.CrossProcessHttpPrefix}/intervention.js"">' + '</scr' + 'ipt>');
-              </script>
-            "));
-            Server.SetRedirect("/intervention.js", "/redirect.js");
-
-            string interventionHeader = null;
-            Server.SetRoute("/redirect.js", context =>
-            {
-                interventionHeader = context.Request.Headers["intervention"];
-                return context.Response.WriteAsync("console.log(1);");
-            });
-
-            await Page.SetRequestInterceptionAsync(true);
-            Page.Request += async (sender, e) => await e.Request.ContinueAsync();
-
-            await Page.GoToAsync(TestConstants.ServerUrl + "/intervention");
-
-            Assert.Contains("www.chromestatus.com", interventionHeader);
-        }
-
         [Fact]
         public async Task ShouldWorkWhenPostIsEedirectedWith302()
         {