Roll Chromium to r656675 (#1124)

* Roll Chromium to r654752

* Roll Chromium to r656675

lib/PuppeteerSharp.Tests/ExecutionContextTests/QueryObjectsTests.cs

@@ -24,7 +24,6 @@ public async Task ShouldWork()
             Assert.Equal(new[] { "hello", "world" }, values);
         }
 
-        [Fact(Skip = "See https://github.com/GoogleChrome/puppeteer/issues/4263")]
         public async Task ShouldWorkForNonBlankPage()
         {
             // Instantiate an object

lib/PuppeteerSharp.Tests/FrameTests/WaitForNavigationTests.cs

@@ -32,18 +32,19 @@ await Task.WhenAll(
         }
 
         [Fact]
-        public async Task ShouldResolveWhenFrameDetaches()
+        public async Task ShouldFailWhenFrameDetaches()
         {
             await Page.GoToAsync(TestConstants.ServerUrl + "/frames/one-frame.html");
             var frame = Page.FirstChildFrame();
             Server.SetRoute("/empty.html", context => Task.Delay(10000));
             var waitForNavigationResult = frame.WaitForNavigationAsync();
             await Task.WhenAll(
-             Server.WaitForRequest("/empty.html"),
-            frame.EvaluateFunctionAsync($"() => window.location = '{TestConstants.EmptyPage}'"));
+                Server.WaitForRequest("/empty.html"),
+                frame.EvaluateFunctionAsync($"() => window.location = '{TestConstants.EmptyPage}'"));
 
-            await Page.QuerySelectorAsync("iframe").EvaluateFunctionAsync("frame => frame.remove()");
-            var response = await waitForNavigationResult;
+            await Page.QuerySelectorAsync("iframe").EvaluateFunctionAsync("frame => frame.remove()");
+            var exception = await Assert.ThrowsAsync<PuppeteerException>(() => waitForNavigationResult);
+            Assert.Equal("Navigating frame was detached", exception.Message);
         }
     }
 }

lib/PuppeteerSharp.Tests/PageTests/EvaluateTests.cs

@@ -82,9 +82,7 @@ public async Task ShouldThrowWhenEvaluationTriggersReload()
             {
                 return Page.EvaluateFunctionAsync(@"() => {
                     location.reload();
-                    return new Promise(resolve => {
-                        setTimeout(() => resolve(1), 0);
-                    });
+                    return new Promise(() => {});
                 }");
             });
 

lib/PuppeteerSharp/BrowserFetcher.cs

@@ -37,7 +37,7 @@ public class BrowserFetcher
         /// <summary>
         /// Default Chromium revision.
         /// </summary>
-        public const int DefaultRevision = 650583;
+        public const int DefaultRevision = 656675;
 
         /// <summary>
         /// Gets the downloads folder.

lib/PuppeteerSharp/CookieParam.cs

@@ -68,5 +68,10 @@ public class CookieParam
         /// <value>Whether it's session only or not.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public bool? Session { get; set; }
+        /// <summary>
+        /// Gets or sets the cookies SameSite value.
+        /// </summary>
+        [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
+        public SameSite? SameSite { get; set; }
     }
 }

lib/PuppeteerSharp/SameSite.cs

@@ -0,0 +1,29 @@
+using Newtonsoft.Json;
+using PuppeteerSharp.Helpers.Json;
+
+namespace PuppeteerSharp
+{
+    /// <summary>
+    /// SameSite values in cookies
+    /// </summary>
+    [JsonConverter(typeof(FlexibleStringEnumConverter), None)]
+    public enum SameSite
+    {
+        /// <summary>
+        /// None
+        /// </summary>
+        None,
+        /// <summary>
+        /// Strict
+        /// </summary>
+        Strict,
+        /// <summary>
+        /// Lax
+        /// </summary>
+        Lax,
+        /// <summary>
+        /// Extended
+        /// </summary>
+        Extended
+    }
+}