Sync Request.Continue tests (#1058)

hardkoded · Apr 6, 2019 · 87fd1df · 87fd1df
1 parent 867677c
commit 87fd1df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/PuppeteerSharp.Tests/NetworkTests/RequestContinueTests.cs b/lib/PuppeteerSharp.Tests/NetworkTests/RequestContinueTests.cs
@@ -96,7 +96,7 @@ public async Task ShouldAmendPostData()
                 await e.Request.ContinueAsync(new Payload
                 {
                     Method = HttpMethod.Post,
-                    PostData = "FooBar"
+                    PostData = "doggo"
                 });
             };
             var requestTask = Server.WaitForRequest("/sleep.zzz", async request =>
@@ -112,7 +112,7 @@ await Task.WhenAll(
                 Page.GoToAsync(TestConstants.ServerUrl + "/sleep.zzz")
             );
 
-            Assert.Equal("FooBar", await requestTask.Result);
+            Assert.Equal("doggo", await requestTask.Result);
         }
     }
 }
diff --git a/lib/PuppeteerSharp/Request.cs b/lib/PuppeteerSharp/Request.cs
@@ -148,6 +148,7 @@ internal Request(
 
         /// <summary>
         /// Continues request with optional request overrides. To use this, request interception should be enabled with <see cref="Page.SetRequestInterceptionAsync(bool)"/>. Exception is immediately thrown if the request interception is not enabled.
+        /// If the URL is set it won't perform a redirect. The request will be silently forwarded to the new url. For example, the address bar will show the original url.
         /// </summary>
         /// <param name="overrides">Optional request overwrites.</param>
         /// <returns>Task</returns>