Relax request matching heuristic (#894)

hardkoded · Feb 2, 2019 · ff53a36 · ff53a36
1 parent e764317
commit ff53a36
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/lib/PuppeteerSharp.Tests/PageTests/SetRequestInterceptionTests.cs b/lib/PuppeteerSharp.Tests/PageTests/SetRequestInterceptionTests.cs
@@ -1,4 +1,4 @@
-using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Http;
 using System;
 using System.Collections.Generic;
 using System.IO;
@@ -41,7 +41,7 @@ public async Task ShouldIntercept()
             Assert.Equal(TestConstants.Port, response.RemoteAddress.Port);
         }
 
-        [Fact(Skip = "Ignored on Puppeteer")]
+        [Fact]
         public async Task ShouldWorkWhenPostIsEedirectedWith302()
         {
             Server.SetRedirect("/rredirect", "/empty.html");

diff --git a/lib/PuppeteerSharp/Payload.cs b/lib/PuppeteerSharp/Payload.cs
@@ -14,6 +14,16 @@ namespace PuppeteerSharp
     /// </summary>
     public class Payload
     {
+        private static readonly ISet<string> IgnoredHeaders = new HashSet<string>(StringComparer.OrdinalIgnoreCase)
+        {
+            "accept",
+            "referer",
+            "x-devtools-emulate-network-conditions-client-id",
+            "cookie",
+            "origin",
+            "content-type"
+        };
+
         /// <summary>
         /// Gets or sets the HTTP method.
         /// </summary>
@@ -64,12 +74,7 @@ internal string Hash
                 {
                     foreach (var item in Headers.OrderBy(kv => kv.Key))
                     {
-                        bool HeaderEquals(string name) => item.Key.Equals(name, StringComparison.OrdinalIgnoreCase);
-
-                        if (HeaderEquals("accept")
-                            || HeaderEquals("referer")
-                            || HeaderEquals("x-devtools-emulate-network-conditions-client-id")
-                            || HeaderEquals("cookie"))
+                        if (IgnoredHeaders.Contains(item.Key))
                         {
                             continue;
                         }