Microsoft Edge Friendly tests #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We made some minor changes to our tests so they run with Microsoft Edge: * Intervention header has the URL https://to-be-replaced.invalid/feature/5718547946799104 instead of https://www.chromestatus.com/feature/5718547946799104. We are changing the "Contains" part * We are removing some new lines and using Trim to compare TextAsync * Edge launches two pages with default arguments. We are going to check that the pages array is not empty.
@kblok did the puppeteer project make these changes as well? |
|
@Meir017 No. Do you think I should add some comments as a reference? |
|
I think a comment should be enough. |
|
@Meir017 both are great ideas. |
|
Comment added @Meir017 |
Meir017
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made some minor changes to our tests so they run with Microsoft Edge: