Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch browser contexts from Dictionary to ConcurrentDictionary #1899

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Switch browser contexts from Dictionary to ConcurrentDictionary #1899

merged 1 commit into from
Jan 20, 2022

Conversation

Thomas-GH-CA
Copy link
Contributor

Switch browser contexts from Dictionary to ConcurrentDictionary due to rare race condition throwing non-concurrent error

kblok
kblok approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Thomas-GH-CA Thomas-GH-CA mentioned this pull request Jan 20, 2022
Closed
@Thomas-GH-CA
Copy link
Contributor Author

Thomas-GH-CA commented Jan 20, 2022 •
edited
Loading

Is that a flaky test or something i should look at ?
ShouldSetThePageCloseState.
I ran it locally and it was fine...
Looks like the above is irrelevant, the Core + Net Framework tests are green now.

@kblok
Copy link
Member

kblok commented Jan 20, 2022

rebuilt :)

@kblok kblok merged commit 773e851 into hardkoded:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kblok kblok kblok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas-GH-CA @kblok