Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementHandle.ScrollIntoViewIfNeededAsync public #1984

Merged
merged 1 commit into from
Jul 4, 2022
Merged

ElementHandle.ScrollIntoViewIfNeededAsync public #1984

merged 1 commit into from
Jul 4, 2022

Conversation

Mephisto090
Copy link
Contributor

@Mephisto090 Mephisto090 commented Jul 3, 2022 •
edited
Loading

So that the user can choose a variable point where to press in the button

#1985

@Mephisto090
ElementHandle.ScrollIntoViewIfNeededAsync public
9fb90d9 
So that the user can choose a variable point where to press in the button
@Mephisto090 Mephisto090 mentioned this pull request Jul 3, 2022
Merged
kblok
kblok approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's private on puppeteer. But I agree on exposing this.

@kblok kblok merged commit 8b3aa8b into hardkoded:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kblok kblok kblok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mephisto090 @kblok