Fix duplicated test #2092
Merged
Fix duplicated test #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thank you! |
|
It seems that the test didn't pass :( |
ShouldWorkWithFakeClickingTargetBlankAndReNoopener and ShouldWorkWithFakeClickingTargetBlankAndRelNoopener were identical. The first one should use 'rel=opener' https://github.com/puppeteer/puppeteer/blob/415da9230066e5b399f60963b639bfbafdc8ec57/test/src/page.spec.ts#L296-L346
jnyrup
force-pushed
the
PageEventsPopupTests
branch
from
52ed558
to
4cc7c44
Compare
|
I missed that the assertions also changed in the corresponding puppeteer test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShouldWorkWithFakeClickingTargetBlankAndReNoopenerandShouldWorkWithFakeClickingTargetBlankAndRelNoopenerare identical.The first one should use
rel=openerCross-checked with puppeteer source