Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Headers from extraInfo when available #2224

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Use Headers from extraInfo when available #2224

merged 1 commit into from
Jun 9, 2023

Conversation

jnyrup
Copy link
Contributor

@jnyrup jnyrup commented Jun 9, 2023

No tests seems to be asserting on this feature.
And only a few tests produces different extra.Headers responseMessage.Headers.
For e.g. ShouldProperlyReportHttpOnlyCookie extraInfo.Headers has an extra Set-Cookie header that responseMessage.Headers does not have.

kblok
kblok approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kblok kblok merged commit a5377ce into hardkoded:master Jun 9, 2023
@jnyrup jnyrup deleted the headers branch June 13, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kblok kblok kblok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnyrup @kblok