Upgrade chrome to 1108766 #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
reviewed
Jul 23, 2023
Comment on lines
43
to
50
| Assert.Contains( | ||
| "Navigating frame was detached", | ||
| new[] | ||
| { | ||
| "Navigating frame was detached", | ||
| "Error: NS_BINDING_ABORTED", | ||
| "net::ERR_ABORTED", | ||
| }); |
There was a problem hiding this comment.
Is this change intentional? The assertion is now always true as both subject and expectation are fixed values.
There was a problem hiding this comment.
This matches the change upstream 🤷
There was a problem hiding this comment.
No :)
The upstream asserts that error.message contains at least one of the three elements.
This change asserts that either of the three elements is "Navigating frame was detached".
There was a problem hiding this comment.
This is the best I can come up with xUnit
Assert.Contains(new[] { exception.Message }, message => new[]
{
"Navigating frame was detached",
"Error: NS_BINDING_ABORTED",
"net::ERR_ABORTED"
}.Any(error => message.Contains(error)));There was a problem hiding this comment.
With FluentAssertions it can be written as
exception.Message.Should().ContainAny(
"Navigating frame was detached",
"Error: NS_BINDING_ABORTED",
"net::ERR_ABORTED"
);There was a problem hiding this comment.
Oops you're so right 😅
The test passes right? 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2258