Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use byte array in message send to avoid some unnecessary encoding #2749

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

campersau
Copy link
Contributor

Similar to #2748 System.Text.Json can also serialize directly to bytes to avoid some unnecessary en/decoding.

Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that I need to revert your previous PR.
Both are breaking changes. IConnectionTransport and MessageReceivedEventArgs are public.
I will point this PR to a v20 branch. and create a new PR with the other change also pointing to v20.

Makes sense?

@campersau
Copy link
Contributor Author

Yes, makes sense.

@kblok kblok changed the base branch from master to v20 August 21, 2024 16:37
@kblok kblok merged commit e326c6c into hardkoded:v20 Aug 21, 2024
12 checks passed
@campersau campersau deleted the sendbytes branch August 21, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants