-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust chrome process clean-up (take 2) #585
Conversation
0ac87d5
to
2e9cc63
Compare
2e9cc63
to
b30afbb
Compare
92360b6
to
c93643f
Compare
c93643f
to
f6376a2
Compare
@kblok I have replaced various |
@ggeurts Can we revert that and discuss that in another PR? |
@kblok I can revert, but it will result in a hanging test. The message sending and receiving portions of the code must deal with concurrency because nothing stops a client from initiating multiple sends before awaiting the results, or from disposing a browser when not all messages have been processed yet. I don't see a way here to achieve safe code without using locks. Having said that, I am willing to extract most of the latest changes into a separate pull request. |
This reverts commit f6376a2.
… and response message handling
@kblok Ok, I have removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments, but this is ready to go!
Compared to #544 the following changes were made:
ChromiumProcess
class ignores exceptionsBrowser.CloseAsync
uses a timeout for graceful close attempts