We don't need no dynamics #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meir017
requested changes
Dec 28, 2018
| @@ -173,8 +174,8 @@ internal async Task<JSHandle> EvaluateFunctionHandleAsync(string script, params | |||
| } | |||
| } | |||
|
|
|||
| internal JSHandle CreateJSHandle(dynamic remoteObject) | |||
| => (remoteObject.subtype == "node" && Frame != null) | |||
| internal JSHandle CreateJSHandle(JToken remoteObject) | |||
There was a problem hiding this comment.
do we want to create a class for this?
There was a problem hiding this comment.
This is the shape of the Token (adding this for reference)
There was a problem hiding this comment.
I will implement a class @Meir017 the shape will be a composition of that ;)
| { | ||
| internal class EvaluateHandleResponse | ||
| { | ||
| public JToken ExceptionDetails { get; set; } |
| @@ -1865,7 +1866,7 @@ private async Task<object> ExecuteBinding(BindingCalledResponse e) | |||
| if (taskResult.GetType().IsGenericType) | |||
| { | |||
| // the task is already awaited and therefore the call to property Result will not deadlock | |||
| result = ((dynamic)taskResult).Result; | |||
| result = taskResult.GetType().GetProperty(taskResultPropertyName).GetValue(taskResult); | |||
There was a problem hiding this comment.
the old way was weird but this also feels a bit odd, is there a clean way to do this?
There was a problem hiding this comment.
Created an issue for this #824
lib/PuppeteerSharp/Page.cs
Outdated
| { | ||
| if (e.Entry.Args != null) | ||
| { | ||
| foreach (var arg in e.Entry?.Args) | ||
| { | ||
| RemoteObjectHelper.ReleaseObject(Client, arg, _logger); | ||
| await RemoteObjectHelper.ReleaseObjectAsync(Client, arg, _logger); |
There was a problem hiding this comment.
is this missing .ConfigureAwait(false) ?
|
Ready to review again @Meir017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #97