Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deref polymorphism (using
Deref
to emulate inheritance) is a Rust anti-pattern. I tried to look up a definition forset_variation
, and could not find one - this is because it was actually defined on a different object which we magically morph into; not easy to follow.I kept a facade method for
tables
since that avoids exposing thettfp_face
implementation outside of thehb_font_t
structure, but inside it, explicit is better than implicit.