Change Future to DeprecationWarning for make_block_same_class (pandas…

…-dev#19442)
harisbal · Feb 28, 2018 · e4e7255 · e4e7255
1 parent ab51851
commit e4e7255
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pandas/core/internals.py b/pandas/core/internals.py
@@ -230,7 +230,7 @@ def make_block_same_class(self, values, placement=None, ndim=None,
         if dtype is not None:
             # issue 19431 fastparquet is passing this
             warnings.warn("dtype argument is deprecated, will be removed "
-                          "in a future release.", FutureWarning)
+                          "in a future release.", DeprecationWarning)
         if placement is None:
             placement = self.mgr_locs
         return make_block(values, placement=placement, ndim=ndim,

diff --git a/pandas/tests/internals/test_internals.py b/pandas/tests/internals/test_internals.py
@@ -288,9 +288,10 @@ def test_delete(self):
     def test_make_block_same_class(self):
         # issue 19431
         block = create_block('M8[ns, US/Eastern]', [3])
-        with tm.assert_produces_warning(FutureWarning,
+        with tm.assert_produces_warning(DeprecationWarning,
                                         check_stacklevel=False):
-            block.make_block_same_class(block.values, dtype=block.values.dtype)
+            block.make_block_same_class(block.values.values,
+                                        dtype=block.values.dtype)
 
 
 class TestDatetimeBlock(object):