port the fix from go-ethereum for interface conversion panic #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoHChen
approved these changes
Apr 12, 2020
fxfactorial
reviewed
Apr 12, 2020
| @@ -240,6 +240,9 @@ func NewBlockChain( | |||
| if bc.genesisBlock == nil { | |||
| return nil, ErrNoGenesis | |||
| } | |||
| var nilBlock *types.Block | |||
There was a problem hiding this comment.
What is context for this fix and why a nil pointer solves it ?
There was a problem hiding this comment.
I don't think this fixes it because this is still a nil pointer. The code will explode because loadLastState will probably explode via currentBlock.Root() or something else because many things will call something on block which will use header.
There was a problem hiding this comment.
it is not a generic fix, but it will surely fix the exact stack trace mentioned in the above issue that happens due to interface conversion from nil to *types.Block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.