do not return bech32 in receipt, fix 7% fee #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GheisMohammadi
approved these changes
Dec 14, 2023
diego1q2w
reviewed
Dec 14, 2023
MaxMustermann2
changed the title
diego1q2w
approved these changes
Dec 14, 2023
diego1q2w
reviewed
Dec 14, 2023
diego1q2w
reviewed
Dec 14, 2023
ONECasey
approved these changes
Dec 14, 2023
adsorptionenthalpy
approved these changes
Dec 15, 2023
* fix: max-rate bellow the era min-rate * fix comments * add localnet epoch config * update config * update config * update config * update config * add log * remove hip30 from localnet * disable localnet config
use the same receipt as `hmyv2_`. using a boolean variable, decide if the addresses need to be converted to bech32. do not return a contract address unless a contract was actually deployed in the transaction by using a pointer address type.
with the switch to `v2.NewReceipt` for even `eth_` queries, the `eth.NewReceipt` function is no longer used
blocks was referring to `blocks of code` and not blocks in a chain. removed the confusing word
MaxMustermann2
force-pushed
the
fees-fix-v2
branch
from
f118bf3 to
45e2518
Compare
diego1q2w
approved these changes
Dec 15, 2023
ONECasey
reviewed
Dec 15, 2023
|
See #4593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is built on top of #4582 to fix the response of
eth_getTransactionReceiptwhile retaining compatibility with eth tooling.There is still a leftover bug in the 7% fee implementation that I discovered while doing some localnet tests. This pull request fixes that and adds some minor cleanup / validation logic.