stable localnet with external #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GheisMohammadi
approved these changes
Sep 10, 2024
mur-me
reviewed
Sep 10, 2024
mur-me
approved these changes
Sep 10, 2024
mur-me
approved these changes
Sep 10, 2024
|
crosslink calculated 16 for localnet and 64 for all others |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: Updated the
make-debug extto ensure that 64 blocks per epoch are used, as crosslink and staking data are re-calculated every 64 blocks. Setting anything below this would cause shard 1 external validator calculations to fail.Localnet Config: During the execution of the localnet, the Harmony process would occasionally start using ports
127.0.0.1:9054or9154, which are unnecessary in this instance and result in failure.Note : that PR would build a -dirty binary when launching the localnet with external