Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background image replacement crop & resize tool #193

Merged
merged 7 commits into from
Jun 5, 2023

Conversation

WiIIiam278
Copy link
Member

@WiIIiam278 WiIIiam278 commented Jun 5, 2023

Closes #122

Adds a UI for resizing and cropping background images.

You can drag the image around, use ctrl+scroll to quickly scale, and use the arrowkeys to (or use the UI to do these things).

There's also a function for auto-scaling and resetting the image position, and it tracks the aspect ratio to make scaling a bit less painful.

Screenshots

image
image
image

Might still need a bit of code cleanup / tweaks here and there -- but feel free to review

@WiIIiam278 WiIIiam278 requested a review from jonko0493 June 5, 2023 15:33
@WiIIiam278 WiIIiam278 self-assigned this Jun 5, 2023
@jonko0493
Copy link
Member

This is so good!!

After testing on Windows, I have two notes:

  • On Windows, the image does not show up until you attempt to resize it
  • I would like for the Ctrl+Scroll & arrow keys controls to be documented in the window itself so that it's obvious those can be used

@jonko0493
Copy link
Member

Same issues apply to Linux.

@WiIIiam278
Copy link
Member Author

Should be fixed

@jonko0493
Copy link
Member

Is fixed, but now one more issue:
image
the buttons are off the screen

Copy link
Member

@jonko0493 jonko0493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work. Let's merge it :)

@WiIIiam278 WiIIiam278 merged commit e8279e4 into haroohie-club:main Jun 5, 2023
@WiIIiam278 WiIIiam278 deleted the bg-crop-resize branch June 5, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BG crop/resize tool
2 participants