Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SFX items & Character voice font/text timer preview/editing #293

Merged
merged 13 commits into from
Jun 26, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Jun 26, 2023

Closes #212. Closes #245.

This adds SFX items (but does not make them editable). It allows for previewing them with (unfortunately) a new sound player that uses modified versions of Gota7's SDAT tech used in Nitro Studio 2. I also added the ability to export a wav of an SFX using the same tech.

Additionally, this shows the bank that the SFX uses, and the groups which contain the SFX. The groups in particular are important as they are what determine which sounds are playable in a given scene. It's unknown where the game decides which groups to load for a given scene at this time.

Finally, now that we can preview the voice font, we allow specifying a different sound effect to use and allow changing the text timer as well.

Oh, and we bump the versions to 0.3 preview now. :)

@jonko0493 jonko0493 self-assigned this Jun 26, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessly -- excellent job! (barring fixing up those tests) ah you did this

@jonko0493 jonko0493 merged commit 340cee2 into haroohie-club:main Jun 26, 2023
@jonko0493 jonko0493 deleted the VoiceFontAndSfxMaybe branch June 26, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make voice font and text timer editable Add SFX items
2 participants