Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge pipeline for UI testing on Windows #316

Merged
merged 67 commits into from
Jan 12, 2024

Conversation

jonko0493
Copy link
Member

Closes #312.

Based on the same branch as the other PR I have open right now. That one should merge first and then this one's changes will become more comprehensible.

It's possible to run these tests locally, but they require a bit of setup. There is some special casing introduced specifically to ensure the tests will run both locally and on the agent.

The two UI tests introduced in this PR are:

  • A test designed to catch an unlikely reintroduction of About dialog crashes if opened after closing #83. It's a super simple test that just opens/closes the about dialog twice.
  • A scenario test for ASM hack application which tests both applying and reverting a single hack (notably, this hack only applies to the overlays -- perhaps we should consider expanding this test/adding a new test to test an ARM9 hack as well).

@jonko0493 jonko0493 self-assigned this Jan 12, 2024
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell so far.

I don't have a Windows machine at the moment unfortunately so can't test this locally - but would certainly be intrigues to give this ago writing some tests for mac.

It's a slight shame that it seems like we'll have to write platform-specific tests, but obviously in the case of the examples you illustrated they are rather platform specific. With that said, they seem quite nice to write (looks like it's quite trivial to select stuff by name attribute, etc).

We should probably add some light documentation on how to execute tests and what that requires to README or the docs.

@jonko0493
Copy link
Member Author

Adding documentation on test running to the README makes sense to me. I don't think it's important to an end-user, so I would leave it out of the docs.

@jonko0493 jonko0493 merged commit dbb115d into haroohie-club:main Jan 12, 2024
4 checks passed
@jonko0493 jonko0493 deleted the AddUiTestFramework branch January 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard to Appium for Windows UI unit testing
2 participants