-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merge pipeline for UI testing on Windows #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell so far.
I don't have a Windows machine at the moment unfortunately so can't test this locally - but would certainly be intrigues to give this ago writing some tests for mac.
It's a slight shame that it seems like we'll have to write platform-specific tests, but obviously in the case of the examples you illustrated they are rather platform specific. With that said, they seem quite nice to write (looks like it's quite trivial to select stuff by name attribute, etc).
We should probably add some light documentation on how to execute tests and what that requires to README or the docs.
Adding documentation on test running to the README makes sense to me. I don't think it's important to an end-user, so I would leave it out of the docs. |
Closes #312.
Based on the same branch as the other PR I have open right now. That one should merge first and then this one's changes will become more comprehensible.
It's possible to run these tests locally, but they require a bit of setup. There is some special casing introduced specifically to ensure the tests will run both locally and on the agent.
The two UI tests introduced in this PR are: