Add Mac UI tests with Appium #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, added some ASM hack tests, so yay! We have functional UI tests for both Windows and Mac now. |
WiIIiam278
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315.
Tested and working locally and on Azure DevOps.
Haven't written the ASM hacks one for this yet so not quite parity with the Windows tests, but that fine for now, probably?Wrote them lolThe screenshots that this one produces are way more useful than the ones that Windows produces, so that's also nice (unfortunate for Windows tho).
This also introduces a slight change in the main app's behavior as well: when looking for the devkitARM path on new install, we first check for the
DEVITKARMenvironment variable (since this gets set on install). We then check that this path exists (as on Windows that variable can be set to/opt/devkitpro/devkitARM) and then proceed with the old behavior if it doesn't. This allows us to set up bootstrapped devkitARM on the mac agents since we can't install things to/opt.Oh, while I'm here, the official build broke last night due to the net8.0 upgrade, so this fixes that.