Add item items #338
Merged
Add item items #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only thing left to do here is to add an Item icon by @WiIIiam278! |
WiIIiam278
requested changes
Jan 28, 2024
| @@ -1998,6 +2024,35 @@ private void UpdatePreview() | |||
| canvas.DrawBitmap(spriteBitmap, sprite.Positioning.GetSpritePosition(spriteBitmap), sprite.PalEffect); | |||
| } | |||
|
|
|||
| // Draw items | |||
| ScriptItemCommand lastItemCommand = commands.LastOrDefault(c => c.Verb == CommandVerb.ITEM_DISPIMG); | |||
There was a problem hiding this comment.
Can we move this routine above the character sprite drawing? In-game, Items render behind characters (I think)
versus in game...
WiIIiam278
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235.
This fully adds item items to SL -- it adds an item editor (allowing them to be replaced), adds new script parameters for items (controlling their location and transition), updates the
ITEM_DISPIMGcommand in the script editor to use these new script parameters and an image selector for the item itself, and adds them to the script preview.