Add character sprite editor, remove SLG maps as options from ADV mode #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem where swapping between large/small sprites wouldn't work. That has been fixed with a lot of RE work into figuring out how textures get allocated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lacks any UI, but it works (with caveats)!
Firstly, fixes #101 as that was just a result of TAID0 (the gym map) happening to be a puzzle phase map! Weird since it's not labeled like the others.
Secondly, closes #89, finally! With some caveats. Notably:
As a result, you can't set the position of the eye and mouth animations! They're currently hardcoded to random values to prove that they work, but will need UI to actually implement. We also might consider embedding the positions in the body's filename (like we do timings).Fixed, you can now do this through filename.Currently, it doesn't save changes to CHRDATA.S, so changes to the character and marking it as large or not don't propagate currently. I'll fix this before merge.Fixed.